Route the Voxtype model picker to the install flow when voxtype is missing - #8631
Open
alexandru-savinov wants to merge 1 commit into
Open
Route the Voxtype model picker to the install flow when voxtype is missing#8631alexandru-savinov wants to merge 1 commit into
alexandru-savinov wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Routes the Voxtype model command to installation when Voxtype is unavailable.
Changes:
- Adds the missing-command guard and preserves shell restart behavior after model selection.
- Adds tests covering installed and missing Voxtype paths.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
bin/omarchy-voxtype-model |
Routes missing Voxtype to its installer. |
test/shell.d/voxtype-model-test.sh |
Tests both command branches. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #6832, which guards
omarchy-voxtype-configbut leaves the sibling command unguarded.omarchy-voxtype-modelopens the model picker unconditionally:omarchy-launch-floating-terminal-with-presentation "voxtype setup model"Voxtype is optional, so this is reachable before it is installed —
omarchy voxtype modelthen pops a floating terminal containing nothing but the failure:This is the same shape as #6823, and the same remedy: when voxtype is missing, route to the install flow instead, so the command that was meant to configure dictation offers to install it.
That path is easy to reach right now on any non-x86_64 machine, where
voxtype-bincannot install at all (#8530, and the source-build fallback in #8316). I hit it on aarch64 — the manual points users atvoxtype setup modelfor changing models, so a user following the manual on a machine where the installer silently failed lands here.Notes
if/elserather than Route dictation config to the install flow when voxtype is missing #6832'sexec, perAGENTS.md: "Prefer a fullif/elseconditional for simple two-path control flow; don't rely onexecorexitin one branch to make following statements unreachable." Happy to match Route dictation config to the install flow when voxtype is missing #6832's shape instead if consistency between the two commands is preferred.omarchy-restart-shellstays on the installed path only; the installer already reloads Hyprland and restarts the shell itself.Tests
Adds
test/shell.d/voxtype-model-test.sh, covering both branches. Presence is stubbed rather than probed so the branch under test doesn't depend on whether the developer's own machine has Voxtype installed. Verified it fails against the unpatched script../test/all:test/clipasses;test/shellpasses 202/207. The 5 failures (bar-icon-geometry,config,snapper,theme-install-guards,unowned-system-paths) reproduce identically on a clean checkout ofquattroon this machine and are unrelated to this change.